Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] prop-types: handle nested forwardRef + memo #3679

Merged
merged 1 commit into from
Feb 18, 2024
Merged

[Fix] prop-types: handle nested forwardRef + memo #3679

merged 1 commit into from
Feb 18, 2024

Conversation

developer-bandi
Copy link
Contributor

Fix #3521

  • Modified to allow an exception that skips the type check of memo when forwardRef and memo are nested.
  • forwardRef, memo, forwardRef with memo testcase add

@developer-bandi @ljharb
[Fix] prop-types: handle nested forwardRef + memo
88f7f09 
Fixes jsx-eslint#3521.

Co-authored-by: 김상두 <[email protected]>
Co-authored-by: Jordan Harband <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f4b2b9) 97.74% compared to head (c1c273c) 97.74%.

❗ Current head c1c273c differs from pull request most recent head 88f7f09. Consider uploading reports for the commit 88f7f09 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3679   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files         132      132           
  Lines        9409     9420   +11     
  Branches     3449     3456    +7     
=======================================
+ Hits         9197     9208   +11     
  Misses        212      212

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb changed the title [FIX] when forwardRef and memo nested, prop-types incorrect [Fix] prop-types: handle nested forwardRef + memo Jan 15, 2024
ljharb
ljharb approved these changes Jan 15, 2024
View reviewed changes
lib/rules/prop-types.js Outdated Show resolved Hide resolved
@ljharb ljharb added the bug label Jan 15, 2024
@ljharb
Copy link
Member

ljharb commented Jan 15, 2024

With the latest rebase, some tests are failing. Can you update to this commit and take a look?

@developer-bandi
Copy link
Contributor Author

developer-bandi commented Jan 15, 2024 •
edited
Loading

@ljharb yes, so I fix the failed test code but almost code is changed. so may be reivew is nessesary

and some Tests are fail because node install fail. i don't know why it is fail. please tell me hint to fix it. (and Automatic Rebase)

ljharb
ljharb requested changes Jan 15, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to worry about the automatic rebase check. The PR now lacks any tests, is that intentional?

lib/rules/prop-types.js Outdated Show resolved Hide resolved
@developer-bandi
Copy link
Contributor Author

developer-bandi commented Jan 16, 2024 •
edited
Loading

You don't have to worry about the automatic rebase check. The PR now lacks any tests, is that intentional?

no, it is not intentional. it's my mistake. perhaps i did pull at local codebase, that test code is deleted.
so i revert all test code already exist

@ljharb ljharb mentioned this pull request Jan 31, 2024
Open
2 tasks
@ljharb ljharb merged commit 88f7f09 into jsx-eslint:master Feb 18, 2024
309 checks passed
@BuloZB BuloZB mentioned this pull request May 19, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request May 24, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
Open
@mjperrins mjperrins mentioned this pull request May 30, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Jun 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jun 3, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jun 3, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Jun 3, 2024
Open
This was referenced Jun 3, 2024
Open
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jun 4, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 5, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@scatools-demo scatools-demo mentioned this pull request Oct 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Oct 4, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 4, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 4, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 4, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@scatools-demo scatools-demo mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 4, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 6, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Error react/prop-types , although the type has been specified
2 participants
@developer-bandi @ljharb